Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 more vscode command implementations #14093

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

This adds the following 3 api commands from vscode:
vscode.executeFoldingRangeProvider
vscode.executeCodeActionProvider
vscode.executeWorkspaceSymbolProvider

How to test

this extension https://github.com/jonah-iden/theia-notebook-selection-test adds 3 new commands named the same as the one added.
executeFoldingRangeProvider executes the command for the active text document
executeCodeActionProvider executes the command for the active text document at the current selection
executeWorkspaceSymbolProvider executes the command with the query "test"

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew August 29, 2024 10:11
@msujew msujew changed the title added 3 vscode execute commands Add 3 more vscode command implementations Aug 29, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msujew msujew added vscode issues related to VSCode compatibility commands issues related to application commands labels Aug 29, 2024
@msujew msujew merged commit 82b4ae2 into master Aug 29, 2024
11 checks passed
@msujew msujew deleted the jiden/add-vscode-exeucution-commands branch August 29, 2024 10:38
@github-actions github-actions bot added this to the 1.53.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands issues related to application commands vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants