Fix vscode api notebook selection property #14087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fixes the selection property of the vscode api notebook object
How to test
you can find a small test extension including vsix file here https://github.com/jonah-iden/theia-notebook-selection-test
This contains a command
Notebook-Test: Get Current Selection
to show current active notebook and its cell selectionFollow-ups
Theia notebooks do not support multi cell select yet. So there is always only one selection and start and end is equal.
Review checklist
Reminder for reviewers