Add support for reverting a composite saveable #14079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Ensures that a composite saveable can be correctly reverted.
This is a follow-up to #14062 and #13916.
How to test
Clone https://github.com/microsoft/vscode-extension-samples.git, build the custom-editor-sample, and copy it to your
theia/plugins
directory.Build and start the Theia Electron or Browser app, and open the
custom-editor-sample
folder in it.Open the
exampleFiles/example.pawDraw
file, and modify it using the custom editor. Save your changes.In the Source Control view, click on the
example.pawDraw
file to open the changes in a side-by-side editor.Using the right-hand side editor, modify the file again, then close the side-by-side editor without saving changes.
Open the
example.pawDraw
file again using eitherOpen File
orOpen Changes
. Verify that your latest changes have been correctly reverted and the editor is not marked as dirty.Review checklist
Reminder for reviewers