Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reverting a composite saveable #14079

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

pisv
Copy link
Contributor

@pisv pisv commented Aug 27, 2024

What it does

Ensures that a composite saveable can be correctly reverted.

This is a follow-up to #14062 and #13916.

How to test

  1. Clone https://github.com/microsoft/vscode-extension-samples.git, build the custom-editor-sample, and copy it to your theia/plugins directory.

  2. Build and start the Theia Electron or Browser app, and open the custom-editor-sample folder in it.

  3. Open the exampleFiles/example.pawDraw file, and modify it using the custom editor. Save your changes.

  4. In the Source Control view, click on the example.pawDraw file to open the changes in a side-by-side editor.

  5. Using the right-hand side editor, modify the file again, then close the side-by-side editor without saving changes.

  6. Open the example.pawDraw file again using either Open File or Open Changes. Verify that your latest changes have been correctly reverted and the editor is not marked as dirty.

Review checklist

Reminder for reviewers

@pisv
Copy link
Contributor Author

pisv commented Aug 27, 2024

@msujew Could you please have a look?

@msujew msujew added diff editor issues related to the diff editor custom-editor issues related to custom-editor functionality labels Aug 27, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@msujew msujew merged commit c40f10c into eclipse-theia:master Aug 27, 2024
11 checks passed
@pisv
Copy link
Contributor Author

pisv commented Aug 27, 2024

Great! Thank you! 👍

@pisv pisv deleted the composite-saveable-revert branch August 27, 2024 15:00
@jfaltermeier jfaltermeier added this to the 1.53.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom-editor issues related to custom-editor functionality diff editor issues related to the diff editor
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants