Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added aliases for list.focusUp and list.focusDown for notebooks #14042

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

Adds aliases for the list.focusUp and list.focusDown commands from vscode for notebooks, so that the j and k keybindings from the jupyter keymaps are working.

How to test

Open a notebook. Select a cell and press j and k to select next or previous cell.
Normal typing should still work in editors and the find widget

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew August 14, 2024 09:15
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

@msujew msujew merged commit 004e2b2 into master Aug 14, 2024
14 checks passed
@msujew msujew deleted the jiden/add-list-focus-aliases-for-notebooks branch August 14, 2024 10:56
@github-actions github-actions bot added this to the 1.53.0 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants