Make sure notebook model created when calling openNotebookDocument #14029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes a bogus behavior when executing
openNotebookDocument()
.openNotebookDocument
should create a NotebookModel (Document) so that a later call of e.g.showNotebookDocument()
is able to open a new editor.A use case is e.g. when you open a notebook file in a text editor and then use
Open in Notebook Editor
link in this text editor. Before this change text editor will be closed, but no new notebook editor will open.How to test
In Explorer use "Open with..." to open a notebook file with a text editor use. If notebook extension is running "Open in Notebook Editor" link should become visible in the editor.
Clicking this link should open a new Notebook editor.
Follow-ups
Review checklist
Reminder for reviewers