Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct cell type for selected language #13983

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 1, 2024

What it does

Finishes the work of #13933 by adding a language selection to markdown notebook cells. When selecting a non-markdown language, any markdown cell automatically becomes a code block of that language.

How to test

  1. Create a markdown cell in a notebook document
  2. Assert that the cell displays a language selection during editing mode.
  3. Change the language to a non-markdown one.
  4. Assert that the cell type changes to a code cell (i.e. doesn't display markdown rendering, and is capable of being executed).
  5. Changing it back is possible by selecting the markdown language again.
  6. The change can also be undone by doing an undo action (via keybinding).

Review checklist

Reminder for reviewers

@msujew msujew added ui/ux issues related to user interface / user experience notebook issues related to notebooks labels Aug 1, 2024
@msujew msujew requested a review from jbicker August 1, 2024 14:56
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as expected.

@msujew msujew force-pushed the msujew/markdown-switch-to-code branch from a3fa16a to ee01067 Compare August 5, 2024 13:15
@msujew msujew merged commit 291bc0e into master Aug 5, 2024
14 checks passed
@msujew msujew deleted the msujew/markdown-switch-to-code branch August 5, 2024 14:03
@github-actions github-actions bot added this to the 1.53.0 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants