Make Notebook preferences registration substitutable #13926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the commonly employed pattern for preference contribution registration to enable substitution of the Notebook preference schema. Fixes eclipse-theia#13913 Signed-off-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
jonah-iden
approved these changes
Jul 15, 2024
msujew
added
preferences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Implement the commonly employed pattern for preference contribution registration to enable substitution of the Notebook preference schema.
Fixes #13913
How to test
Verify that the Notebook preferences appear in the Settings panel as before.
Open some kind of notebook and verify that the specific preference settings have the expected effect on notebook behaviour, output, etc. For example, in a GitHub Issues Notebook, create a code cell, enter some code, and toggle the line numbers preference setting to see how line numbers appear or not in the cell editor.
Follow-ups
No follow-up is identified at this time.
Review checklist
Reminder for reviewers