improved shown keybindings in context menu #13830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This improves the visible keybindings in context menus by not showing keybindings that are inactive in the current context.
How to test
For example add a keybinding like this to some keybinding contribution
previously this was the always shown as
Z
in the context menu regardless of if a notebook editor was focused.Now this should still normally be
ctrl/cmd+z
but when a notebook editor is focused it should show asZ
Follow-ups
Review checklist
Reminder for reviewers