Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop moving to next cell when suggestion widget is visible #13774

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

This disables the moving to another notebook cell via the arrow keys when the suggestion widget is open

How to test

  1. Open a notebook with at least two cells.
  2. Pressing arrow down when on the last line of should then focus the next cell
  3. Type something in the cell to reveal suggestions
  4. Pressing the up arrow now should not move back to the first cell but only the selection inside the suggestion widget

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew June 6, 2024 08:13
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonah-iden jonah-iden merged commit e0517ad into master Jun 6, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/stop-moving-to-cell-when-suggestions branch June 6, 2024 10:12
@github-actions github-actions bot added this to the 1.51.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants