Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editors theme change and widget not attached error #13757

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

There was a problem when closing an editor to the right of the current or the most right one and then changing the theme, the editors would not update correctly. Was probably introduced by the secondary window changes. This should fix it.

Also fixes the small issue of widget not attached errors from the webviews when closing a notebook editor with outputs

How to test

Theming:

  1. open at least two editors, the right one should be a standalone one. Left can be either notebook or standalone.
  2. close the right editor.
  3. change the theme to the opposite theme (dark/light)
  4. see that it now updates correctly (previously the editor would stay on the previous color)

Widget not attached:

  1. just open a notebook with outputs
  2. close it
  3. there should be no widget not attached errors in the console

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew June 4, 2024 13:52
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@jonah-iden jonah-iden merged commit a6fb882 into master Jun 4, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/notebook-fixes branch June 4, 2024 14:19
@github-actions github-actions bot added this to the 1.51.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants