Fix editors theme change and widget not attached error #13757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
There was a problem when closing an editor to the right of the current or the most right one and then changing the theme, the editors would not update correctly. Was probably introduced by the secondary window changes. This should fix it.
Also fixes the small issue of
widget not attached
errors from the webviews when closing a notebook editor with outputsHow to test
Theming:
Widget not attached:
Follow-ups
Review checklist
Reminder for reviewers