Notebooks: Aligned scroll into view behaviour with vscode

[jonah-iden]

What it does

As in vscode clicking a cell to select it or deleting a cell and changing the selection that way should not move the newly selected cell into view

How to test

In a notebook test:

1. clicking on a cell slightly outside of the view. Should not scroll
2. deleting a cell. Should not scroll
3. inserting new cell: Should scroll
4. arrow keys. With and without text focus. Should scroll

Follow-ups

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

This doesn't work as expected for me, see:

2024-05-29.16-58-10.mp4

Clicking on/deleting a cell still scrolls the (potentially non-existing) cell fully into view.

[jonah-iden]

seems i forgot two places two disable scrolling. Thanks for finding! Should be fixed now

[msujew]

Thanks, looks good to me 👍

Something worth mentioning (but can be fixed in a separate PR) would be that focusing and then moving the cursor via the arrow keys scrolls inside of the notebook in VSCode. As the cursor needs to be kept in view. This doesn't work in Theia.