-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate "Save As" operation to plugin host #13689
Conversation
0a186dc
to
c999ba0
Compare
c999ba0
to
b71a8c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @msujew, thank you very much for your change! I do have a few questions and concerns but overall it seems to work as advertised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msujew Thank you for the quick feedback! With the latest changes, I think we are good to go. Everything works as expected and the documentation was adjusted where necessary. Great work!
1435ad3
to
97f91d5
Compare
@msujew I think we can merge this? |
What it does
Closes #13688
Ensures that any new file created from a "Save As" operation correctly fires the
onDidCreateFiles
event in the plugin host. Also greatly simplifies the "Save As" operation logic.How to test
onDidCreateFiles
)Review checklist
Reminder for reviewers