Always resolve existing before showing new notification #13668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #13661
Using the
vscode.window.show<Severity>Message
API in VSCode behaves differently in Theia compared to VSCode when calling the method multiple times. Calling the method again with the same arguments will first off always resolve the previous call withundefined
. Additionally, the newest message will always appear first in the toasts and notification center.This change aligns Theia to this behavior.
How to test
Show Info Notification
and then theShow Warning Notification
command. Both notifications should appear as expectedShow Info Notification
again. The initial call should resolve withundefined
(this is indicated in the backend console). The notification should appear as the first notification in the toasts/notification center.Review checklist
Reminder for reviewers