Select next notebook cell on first or last line of editor #13656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This replicates the behaviour of vscode when having the cursor on the first or last line in a cell editor and pressing
up/downit will select the next/previous cell as if it was one text editor.How to test
Open or create a notebook with multiple cells. Focus an editor and move up down through the cells with the arrow key
Follow-ups
there is not really a difference between edit and command mode currently in theias notebook editor. So when getting to a markdown cell and then moving to a code cell, it will not focus the editor again
Review checklist
Reminder for reviewers