Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kernel autobind for on startup opened notebooks #13598

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix kernel autobind for on startup opened notebooks #13598

merged 1 commit into from
Apr 17, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

this fixes the kernel autobind when a notebook is opened on startup.

How to test

  1. open a notebook
  2. select a kernel
  3. reload the window
  4. notebook should open automaticly
  5. execute a cell
  6. verify it worked correctly

Follow-ups

Review checklist

Reminder for reviewers

@jonah-iden
fix kernel autobind for on startup opened notebooks
73dab6f 
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew April 12, 2024 07:37
msujew
msujew approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, works as expected 👍

@jonah-iden jonah-iden merged commit fea794f into master Apr 17, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/fix-kernel-autobind-on-startup branch April 17, 2024 11:03
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 17, 2024
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
notebook issues related to notebooks
Projects
PR Backlog
Archived in project
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jonah-iden @msujew