-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update electron to ^28.2.8 #13580
chore: update electron to ^28.2.8 #13580
Conversation
The license check fails with
However npm lists the license as MIT, see here. We used |
@sdirix I've instructed clearlydefined.io to harvest the version of that library. It's the data source of the dash license check tool. It's now correctly recognized. |
@msujew Do you want to review/merge this PR? |
@sdirix I can take a look at this tomorrow 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Even the more complex features (i.e. secondary window support) worked as expected for me. However, I could only test on Windows, so anyone with a Mac/Linux PC looking at this would be appreciated.
@sdirix Could you rebase so I can merge this? |
Updates the Electron dependency to ^28.2.8 which is also used in VS Code. Additional changes: - update electron-mocha to ^12.3.0 to fix the Electron smoke test - adds a workaround for a type clash in rebuild.ts
@JonasHelming Done |
What it does
Updates Electron dependency to
^28.2.8
, the same version as used in VS Code.Note: It's not 100% the same version. VS Code is fixed on
28.2.8
while^28.2.8
currently resolves to28.2.10
How to test
Build and run the Electron example application
Follow-ups
Downstream projects like the Theia IDE also need to update then.
Review checklist
Reminder for reviewers
Closes #12855