Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update electron to ^28.2.8 #13580

Merged
merged 1 commit into from
May 7, 2024

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Apr 9, 2024

What it does

Updates Electron dependency to ^28.2.8, the same version as used in VS Code.

Note: It's not 100% the same version. VS Code is fixed on 28.2.8 while ^28.2.8 currently resolves to 28.2.10

How to test

Build and run the Electron example application

Follow-ups

Downstream projects like the Theia IDE also need to update then.

Review checklist

Reminder for reviewers

Closes #12855

@sdirix
Copy link
Member Author

sdirix commented Apr 16, 2024

The license check fails with

ERROR: Found results that aren't part of the baseline!
X npm/npmjs/-/electron-mocha/12.3.0, 

However npm lists the license as MIT, see here.
Same in the repository, see here.

We used electron-mocha before too, this PR just updates it by one major version. How can we resolve this?

@msujew
Copy link
Member

msujew commented Apr 17, 2024

@sdirix I've instructed clearlydefined.io to harvest the version of that library. It's the data source of the dash license check tool. It's now correctly recognized.

@sdirix
Copy link
Member Author

sdirix commented Apr 29, 2024

@msujew Do you want to review/merge this PR?

@msujew
Copy link
Member

msujew commented Apr 29, 2024

@sdirix I can take a look at this tomorrow 👍

@msujew msujew self-requested a review April 29, 2024 13:39
@msujew msujew added electron issues related to the electron target dependencies pull requests that update a dependency file labels Apr 29, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Even the more complex features (i.e. secondary window support) worked as expected for me. However, I could only test on Windows, so anyone with a Mac/Linux PC looking at this would be appreciated.

@JonasHelming
Copy link
Contributor

@sdirix Could you rebase so I can merge this?

Updates the Electron dependency to ^28.2.8 which is also used in VS
Code.

Additional changes:
 - update electron-mocha to ^12.3.0 to fix the Electron smoke test
 - adds a workaround for a type clash in rebuild.ts
@sdirix
Copy link
Member Author

sdirix commented May 6, 2024

@sdirix Could you rebase so I can merge this?

@JonasHelming Done

@JonasHelming JonasHelming merged commit ba95d18 into eclipse-theia:master May 7, 2024
14 checks passed
@sdirix sdirix deleted the electron-update branch May 8, 2024 09:53
@jfaltermeier jfaltermeier added this to the 1.50.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file electron issues related to the electron target
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

electron: upgrade to 25.x.y
4 participants