Support truncated notebook output commands #13555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as scrollable element, open settings) Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
reviewed
Apr 3, 2024
packages/notebook/src/browser/contributions/notebook-output-action-contribution.ts
Outdated
Show resolved
Hide resolved
packages/notebook/src/browser/notebook-cell-resource-resolver.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
changed the title
msujew
approved these changes
Apr 3, 2024
packages/notebook/src/browser/notebook-cell-resource-resolver.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When a text ouput is to long the notebook renders display a message like "Output is truncated. View as a scrollable element or open in a text editor. Adjust cell output settings..."
This PR makes the
scrollable element,text editorandsettingslinks in that message working.How to test
Open a notebook and add a cell like
execute and test the links in the Output is truncated message
Follow-ups
The
scrollable elementis currently just expanding the output. The correct max height needs to be calculated later based on the settings.There are also currently no settings to change the max display size
Review checklist
Reminder for reviewers