Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an exception for @types/qs to the IP check baseline. #13524

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

tsmaeder
Copy link
Contributor

What it does

Fixes failing IP-Checks.

The package is from DefinitelyTyped and therefore MIT-licensed.

https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/13990

Contributed on behalf of STMicroelectronices

How to test

Follow-ups

Review checklist

Reminder for reviewers

The package is from DefinitelyTyped and therefore MIT-licensed.

https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/13990

Contributed on behalf of STMicroelectronices

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks alot for fixing this! LGTM

@tsmaeder
Copy link
Contributor Author

Merging this one in order to deblock development. We can revert if it proves to be the wrong decision.

@tsmaeder tsmaeder merged commit d344b2f into eclipse-theia:master Mar 25, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.48.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants