Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved focusing of the notebook cell editors #13516

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Mar 22, 2024

What it does

This improves focusing of cell editors in multiple ways:

  • code cell editor will now recieve focus when clicking on the code cell status bar below the editor (the are showing python/markdown and the execution state)
  • creating a new code cell now directly focuses the editor
  • creating a new markdown cell now sets the cell into edit mode and focuses the editor
  • when using shift+enter to execute and select next cell, the cursor does not stay in the previous cells editor anymore

How to test

open or create a new notebook. Test the cases listed above

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from jbicker March 22, 2024 10:54
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden changed the title imporved focusing of the notebook editor improved focusing of the notebook editor Mar 22, 2024
@jonah-iden jonah-iden changed the title improved focusing of the notebook editor improved focusing of the notebook cell editors Mar 22, 2024
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Thanks!

@jonah-iden jonah-iden merged commit 774651f into master Mar 25, 2024
12 of 14 checks passed
@jonah-iden jonah-iden deleted the jiden/better-notebook-cell-editor-focus branch March 25, 2024 16:01
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 25, 2024
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants