Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebView Extensions asset load 403 Forbidden #13373 #13382

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Feb 13, 2024

What it does

Fix regression where webview based editors were using the new more stable origin URL from regular web views

Fixes #13373

How to test

See reproducer on issue #13373

Follow-ups

Review checklist

Reminder for reviewers

* fix regression where webview based editors were using the new more
stable origin URL from regular web views
@jfaltermeier jfaltermeier marked this pull request as ready for review February 13, 2024 09:12
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me and works well, thank you, Johannes!

@jfaltermeier jfaltermeier merged commit ef486bd into master Feb 13, 2024
14 checks passed
@jfaltermeier jfaltermeier deleted the jf/webview-403 branch February 13, 2024 14:19
@github-actions github-actions bot added this to the 1.47.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

WebView Extensions asset load 403 Forbidden
2 participants