-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support plugin copying for remote feature #13369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things i noticed while testing.
- It seems to not be able to install all extensions
There were two extensions missing which were install from VSX previously for testing:zaaack.markdown-editor
andms-toolsai.jupyter-keymap
- of the builtin extensions only 26 of 83 were installed. Even basic things like css and dart language basics
- of course extensions installed through
install from vsix
were not installed. That would probably take additional significant effort right?
ok i take that back with the not installed extensions it seems the view just did't update correctly. Maybe it would be nice to have a installing plugins progress message somewhere |
It's nice that launch args can be added via a contribution point, but the way the |
@msujew have you considered:
That considered, wouldn't it make more sense to ship all local plugins to the remote ide? |
I've thought about that, but the main issue here lies with platform specific plugins: If I'm running windows, I will run the native rust-analyzer plugin Windows binaries. Shipping those to the remote ide will stop the plugin from working. We generally don't really have enough information about a plugin to know whether we can just copy it over or whether we have to redownload it on/to the target machine. |
@jonah-iden what's the current state of this one? |
@tsmaeder to be honest im not totally sure. If this is not urgently needed i would wait for mark to get back from vacation. |
4cc05c3
to
571a75a
Compare
@jonah-iden I just rebased on top of Thomas' changes regarding the
Right. It's possible in theory (we can just repackage the unpacked plugin) but I would implement that once it is actually required.
I haven't been able to reproduce this. In all of my tests, all 85 builtins were successfully copied to the remote. |
571a75a
to
41f8c72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. All my installed extensions were copied perfectly fine.
Code looks good to me
What it does
This change adds support for copying plugins from the host system to the remote system. Works in two ways:
--install-plugins
argument. This new runtime CLI argument automatically installs the specified extensions from open-vsx.How to test
Review checklist
Reminder for reviewers