Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to contributed view container ids #13362

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Feb 7, 2024

What it does

Adds the prefix workbench.view.extension. to the id of view containers contributed by plugins. As the id of the view container now contains dots, it can no longer be used as a css selector, so we now generate a sequential id.

Fixes #13249

Contributed on behalf of STMicroelectronics

How to test

I use the tree-view-sample from https://github.com/microsoft/vscode-extension-samples/. The example contributes a view called "Node Dependencies" in a container called "Package Explorer" plus it adds a bunch of views to the standard "Explorer" view container. Make sure you can open/close/reopen the "Package Explorer" view and that all the contributed views are functional, including showing the proper icons.

Follow-ups

Review checklist

Reminder for reviewers

Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me.
I also checked that the 'edit' menu is still showing on the node dependencies item in the tree view sample while adding this check to the 'when' clause of the command: "activeViewlet == 'workbench.view.extension.package-explorer' &&". The behavior is now similar to vscode one.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder merged commit fba46c6 into eclipse-theia:master Feb 13, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.47.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

View Container Id needs Prefix
3 participants