Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying the port of a remote SSH connection #13296

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

planger
Copy link
Contributor

@planger planger commented Jan 19, 2024

What it does

Uses new URL(<host>) to parse the host specified by the user and pass on url.hostname and url.port when establishing the SSH connection. This way we enable users to specify the port of the remote SSH server.

Contributed on behalf of STMicroelectronics.
Fixes #13295

How to test

  1. Start a container with open SSH server running and map it e.g. to port 2222 with docker run -d -p 2222:22 ssh-container
  2. Run Connect to Host...
  3. Enter user@localhost:2222
  4. Observe how the establishing the connection now works

Test whether specifying no port, e.g. user@localhost still works.

Follow-ups

N/A

Review checklist

Reminder for reviewers

@planger planger requested a review from msujew January 19, 2024 20:10
@planger planger added the remote-ssh issues related to the ssh remote functionality label Jan 22, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

Contributed on behalf of STMicroelectronics.
Fixes eclipse-theia#13295

Change-Id: If29f06b34749091797ae861101159195afcc5a8e
@planger planger merged commit a8ee157 into eclipse-theia:master Jan 22, 2024
10 of 14 checks passed
@planger planger deleted the planger/issues/13295 branch January 22, 2024 14:32
@jfaltermeier jfaltermeier added this to the 1.46.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote-ssh issues related to the ssh remote functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remote SSH connection doesn't support ports
3 participants