Add document URI as context to getDefaultFormatter #13280
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgraband
force-pushed
the
GH-13108-multi-root-formatting
branch
from
3191578
to
c2c5224
Compare
|
@eneufeld Could you validate? |
This way the default formatter will be resolved correctly in multi-root workspaces. Beforehand only the workspace settings where taken into account. Now the behavior is as expected, see eclipse-theia#13108 for an example. Fixes eclipse-theia#13108. Contributed on behalf of STMicroelectronics
sgraband
force-pushed
the
GH-13108-multi-root-formatting
branch
from
c2c5224
to
e462122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This way the default formatter will be resolved correctly in multi-root workspaces.
Beforehand only the workspace settings where taken into account.
Now the behavior is as expected (If the workspace does not provide a formatter we take the value from the folder the file is located), see #13108 for an example.
Fixes #13108.
Contributed on behalf of STMicroelectronics
How to test
See #13108 for an example.
Follow-ups
Review checklist
Reminder for reviewers