Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for the file explorer progress bar issue (related to network disconnection) #13268

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

safisa
Copy link
Contributor

@safisa safisa commented Jan 12, 2024

What it does

Fixes:
#13216

How to test

  1. set the frontendConnectionTimeout to some high value (e.g 15000ms)
  2. set the reloadOnReconnect to false
  3. do a network disconnection (or just a web-socket disconnection)
  4. expand any folder in the file explorer
  5. reconnect back
  6. try to expand the folder again: the spinner and progress bar should disappear

Follow-ups

Review checklist

Reminder for reviewers

@tsmaeder tsmaeder merged commit ded2a67 into eclipse-theia:master Jan 15, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.46.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants