Empty VSCode plugin webview editor windows #13258 #13265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* introduce widget manager method to find a widget based on testing its options * use this in webviews-main to also check pending widgets
jfaltermeier
changed the title
* fix {{uuid}} replacements
* use an origin that is computed based on the view type
* move uuid v5 hash method to core
jfaltermeier
changed the title
1 task
| * @returns a uuid | ||
| */ | ||
| export function hashValue(value: string): string { | ||
| return v5(value, NAMESPACE); |
There was a problem hiding this comment.
Since we are using v5 as opposed to v4 here, I assume that we made this choice on purpose to always get the same UUID given the specified value, right? If so I think it would be great to make that even more explicit in the comment. Or is that explicit enough in your opinion, just asking from a very novice point of view.
There was a problem hiding this comment.
Thanks, I've added a comment
* Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #13258
How to test
See the reproducers on #13258 and #13092
Follow-ups
/
Review checklist
Reminder for reviewers