Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update message for missing Electron main entries #13242

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Jan 5, 2024

The warning message for missing Electron main entries still refered to src-gen/frontend. However since Theia 1.39.0 it should be either src-gen/backend or as now indicated lib/backend.

What it does

Update the warning message emitted by the Theia CLI when starting Theia Electron whose package.json does not contain a main entry.

How to test

Remove the main entry of the example Electron application and start it.

Review checklist

Reminder for reviewers

The warning message for missing Electron main entries still refered to
'src-gen/frontend'. However since Theia 1.39.0 it should be either
'src-gen/backend' or as now indicated 'lib/backend'.
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes more sense 👍

@msujew msujew added the electron issues related to the electron target label Jan 9, 2024
@JonasHelming JonasHelming merged commit 6a7bd87 into eclipse-theia:master Jan 10, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.46.0 milestone Jan 25, 2024
@sdirix sdirix deleted the update-main-entry-warning branch February 6, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants