Improve terminalQuickFixProvider stubbed API with vscode 1.85 #13240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu
force-pushed
the
issues/13234
branch
from
947d5ef
to
866b07b
Compare
tsmaeder
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR updates the proposed API for terminalQuickFixProvider, that was updated in vscode 1.85. This API is currently stubbed, so this will not change any behavior
Fixes #13234
Contributed on behalf of STMicroelectronics
How to test
There should be no runtime changes compared to master, as the API is only stubbed. The npm builtin extension depends on this interface, it should still install and run on 1.85 version.
Follow-ups
no follow up.
Review checklist
Reminder for reviewers