Rename Terminal.sendText addNewLine parameter to align with vscode api #13236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschnekenbu
force-pushed
the
issues/13235
branch
from
59f037d
to
ed37e55
Compare
fixes eclipse-theia#13235 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu
force-pushed
the
issues/13235
branch
from
ed37e55
to
f418006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR simply renames a parameter from theia.d.ts and the related implementation. This does not change any behavior, goal is only to remain align with vscode code here.
Fixes #13235
Contributed on behalf of STMicroelectronics
How to test
The test can be done installing the following extension (bundled from vscode extension sample repository) :
zip:
terminal-sample-0.0.1.zip
src:
terminal-sample-0.0.1-src.zip
The extension provides several command prefixed with 'Terminal API'. Among the actions, send text and send text with no new line can be invoked.
Behavior should be equivalent between master and after this PR is applied.
Follow-ups
no follow up.
Review checklist
Reminder for reviewers