Ensure that showOpenDialog returns correct file URI

[tortmayr]

What it does

Use URI.file instead of manually reconstructing the URI from the received file path in plugin ext. This ensures that directories or files that contain a hash are not wrongly added to the fragment component of the URI and aligns it with the expected behavior of VS Code.

Fixes #13074

Contributed on behalf of ST Microelectronics

How to test

Follow instructions described in #13074
When opening a file or folder with a "#" in it the received URI should now look as expected. i.e:

{
scheme: 'file',
path: '/C:/example/#path'
fragment: ''
}

instead of

{
scheme: 'file',
path: '/C:/example/'
fragment: 'path'
}

Follow-ups

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

@tortmayr I'll take a look at this. Can you provide a minimal extension to reproduce this?

[tortmayr]

Sure thing:
Here is the extension + source code:
theia13074.zip

This opens a file dialog on startup.
Select and open a folder / file path that includes a hash (#) (e.g. 'c:/example/#path').
Inspect the received vscode.Uri object properties. (Its logged in the backend).
On master you can observe that the folder name after the # is incorrectly added to the fragment section of the URI.
With this change this behavior is fixed and the URI is correctly constructed and behaves the same as in VS Code.

[msujew]

Perfect, looks good to me 👍