Fix notebook kernel selection #13171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
plug-in system
msujew
commented
Dec 12, 2023
jonah-iden
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Code looks good to me and everything seems to work fine.
Tested with different notebook kernels (python installations, venv and conda) and jupyter_server
the extra options in the cell toolbars contributed by jupyter are not yet working. But i don't think thats in the scope of this PR
msujew
force-pushed
the
msujew/fix-kernel-selection
branch
from
c535b0c
to
36cd699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #13167
Fixes quite a few issues which prevented the notebook kernel selection from working correctly. The most major issue was related to the fact that the safe command wasn't transmitted correctly (it was missing its arguments). See changes in the
command.tsandcommand-registry.tsfile.There where also a few issues related to the way we communicated open/focused editors to the plugin host. This was fixed in
notebook-editor-widget-service.tsandnotebook-documents-and-editors-main.ts.How to test
Review checklist
Reminder for reviewers