Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Support env.onDidChangeShell event #13097

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[vscode] Support env.onDidChangeShell event #13097

merged 1 commit into from
Nov 28, 2023

Commits on Nov 28, 2023

  1. [vscode] Support env.onDidChangeShell event 

    contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>

Address review comments
- remove indirection from TerminalService
-  change shellPath as getter rather than property
- use instanceof instead of is()
    @rschnekenbu
    rschnekenbu committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1f32a87 View commit details
    Browse the repository at this point in the history