Prevent task terminal title from being changed by task process #13003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use server title for task terminals, instead use the provided widget title Signed-off-by: Bryan Chen <Bryan.Chen2@microchip.com>
Signed-off-by: Bryan Chen <Bryan.Chen2@microchip.com>
martin-fleck-at
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Nice catch! This also aligns the behavior with VSCode where a task execution does not change title of the terminal. We already prevent the title change in other places (e.g., debug or the terminal creation through plugins) the same way so very nice contribution. Thank you!
|
@bryanchenmchp Could you please fix the conflict in the CHANGELOG.md? It should be something minor and then we can merge your PR. |
|
Is there a way to re-run failed CI checks? |
I was already out for the day but yes there is but I believe only for committers, I re-triggered the failed check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Set the terminal widget used by tasks to not use server title, so that the title of the task widget is not changed by the task process.
Resolves #13002
How to test
Follow the steps to reproduce in #13002, the terminal title should not change
Follow-ups
N/A
Review checklist
Reminder for reviewers