Fix preload application package import

[msujew]

What it does

Closes #12962

Fixes the import to use one that doesn't rely on node.js dependencies.

How to test

Confirm that the preload functionality behaves as expected.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

@vince-fugnitto I imagine we need a 1.42.1 with this fix, the current 1.42.0 version isn't working well.

[planger]

Thank you for this fix! I can confirm that preload and production build works again for browser with this fix.

I'm sorry for having introduced this issue with #12897, I didn't expect to break the preload / production build with this package level import.

To reveal such an issue in the future early, I'd suggest to run a very simple playwright test on the production mode on every change, which just checks if the application loads correctly. It'd be very easy to set up and I'd be happy to open a PR for that. WDYT?

[msujew]

I'm sorry for having introduced this issue with #12897, I didn't expect to break the preload / production build with this package level import.

All good, I know how it feels to have broken something accidentally ;)

To reveal such an issue in the future early, I'd suggest to run a very simple playwright test on the production mode on every change, which just checks if the application loads correctly. It'd be very easy to set up and I'd be happy to open a PR for that. WDYT?

I wanted to propose something similar. It's not like I had tests for the preload stuff, but I was still suprised that our tests didn't catch the issue. I'm all in for that 👍

[planger]

All good, I know how it feels to have broken something accidentally ;)

Thank you! :-)

I wanted to propose something similar. It's not like I had tests for the preload stuff, but I was still suprised that our tests didn't catch the issue. I'm all in for that 👍

Great, I'll open a PR in the next 1-2 days!
It'd be good to at least have a very simple smoke test for the production build, which currently doesn't seem to be verified at all.

[planger]

For future references: I've opened #12965 to add a smoke test for the production build

[vince-fugnitto]

@vince-fugnitto I imagine we need a 1.42.1 with this fix, the current 1.42.0 version isn't working well.

Sounds good, we can mention it during the dev meeting (tomorrow) and perform the release.