Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsx-registry: add hint to fetching extensions error #12858

Merged
merged 4 commits into from
Sep 20, 2023
Merged

vsx-registry: add hint to fetching extensions error #12858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
724090f
vsx-registry: add hint to fetching extensions error
SamuelBergSTM Aug 21, 2023
281c698
vsx-registry: show only hint for ENOTFOUND error and undo i18n change
SamuelBergSTM Aug 24, 2023
ba7ab2d
vsx-registry: add ENOTFOUND to changelog
SamuelBergSTM Sep 20, 2023
c6e174c
vsx-registry: move changelog entry from v1.41.0 to v1.42.0
SamuelBergSTM Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

- [Previous Changelogs](https://github.com/eclipse-theia/theia/tree/master/doc/changelogs/)

## v1.42.0

- [vsx-registry] added a hint to extension fetching ENOTFOUND errors [#12858](https://github.com/eclipse-theia/theia/pull/12858) - Contributed by STMicroelectronics

## v1.41.0 - 08/31/2023

- [application-package] added handling to quit the electron app when the backend fails to start [#12778](https://github.com/eclipse-theia/theia/pull/12778) - Contributed on behalf of STMicroelectronics.
Expand Down
4 changes: 3 additions & 1 deletion packages/vsx-registry/src/browser/vsx-extensions-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,11 @@ export class VSXExtensionsWidget extends SourceTreeWidget implements BadgeWidget
const searchError = this.extensionsSource.getModel().searchError;
if (!!searchError) {
const message = nls.localize('theia/vsx-registry/errorFetching', 'Error fetching extensions.');
const configurationHint = nls.localize('theia/vsx-registry/errorFetchingConfigurationHint', 'This could be caused by network configuration issues.');
const hint = searchError.includes('ENOTFOUND') ? configurationHint : '';
return <AlertMessage
type='ERROR'
header={`${message} ${searchError}`}
header={`${message} ${searchError} ${hint}`}
/>;
}
}
Expand Down