Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playwright: Update to latest versions and add new page objects #12843

Merged
merged 1 commit into from
Aug 22, 2023
Merged

playwright: Update to latest versions and add new page objects #12843

merged 1 commit into from
Aug 22, 2023

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Aug 21, 2023 •
edited
Loading

What it does

  • Update playwright to the latest version
  • Extend page objects for compact and nested folders
  • Extend ExplorerView tests with compact folders

Signed-off-by: Nina Doschek ndoschek@eclipsesource.com

How to test

  • Run playwright tests via yarn test:playwright from root directory

Review checklist

Reminder for reviewers

@ndoschek
playwright: Update to latest versions and add new page objects
bb3d525 
- Update `playwright` to the latest version
- Extend page objects for compact and nested folders
- Extend ExplorerView tests with compact folders

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
@ndoschek ndoschek mentioned this pull request Aug 21, 2023
Closed
1 task
@ndoschek
Copy link
Contributor Author

Hi @planger, as you already had an initial look at my changes, could you please suggest additional reviewers for this PR? Thank you!

@vince-fugnitto vince-fugnitto added dependencies pull requests that update a dependency file playwright issues related to playwright tests labels Aug 21, 2023
@planger
Copy link
Contributor

planger commented Aug 21, 2023

Thank you, Nina! As mentioned, I'm in favor and already reviewed this change.

I think, recently, @marcdumais-work and @vince-fugnitto had a second look at Playwright-related PRs. Are any of you up to a short review? Thank you very much in advance!

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Aug 21, 2023 •
edited
Loading

@planger I'm fine with the changes to playwright as long as they pass :)
I performed a review for the updated dependencies that we should wait for their approval:

@planger
Copy link
Contributor

planger commented Aug 21, 2023

@vince-fugnitto Thank you very much! I'll add an approve to this PR then and wait for the approval of the updated dependencies before merging.

Thanks again for the swift response and for filing the dependency updates!

@planger planger self-requested a review August 21, 2023 14:30
planger
planger approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

As mentioned above, we'll wait with merging until all dependency updates have been approved.

@JonasHelming
Copy link
Contributor

@planger I think they are approved?

@planger planger merged commit a2a42b7 into eclipse-theia:master Aug 22, 2023
6 checks passed
@ndoschek ndoschek deleted the ndoschek/update-playwright branch August 22, 2023 13:18
@vince-fugnitto vince-fugnitto added this to the 1.41.0 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
dependencies pull requests that update a dependency file playwright issues related to playwright tests
Projects
PR Backlog
Archived in project
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ndoschek @planger @vince-fugnitto @JonasHelming