Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree: fix right-clicking tree nodes bug #12801

Merged
merged 11 commits into from
Aug 17, 2023
Merged

tree: fix right-clicking tree nodes bug #12801

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c2c53a2
handling middle click event
vladarama Jul 28, 2023
68cb3eb
fix toggling node issue
vladarama Jul 31, 2023
11e3124
fix clipboard pasting bug
vladarama Jul 31, 2023
3ed25d7
fix auto-scrolling separately
vladarama Jul 31, 2023
5d0c8cf
remove isWindows import
vladarama Jul 31, 2023
ea85b9a
fix auto-scrolling in trees
vladarama Aug 1, 2023
ab0613e
fix firefox clipboard pasting bug
vladarama Aug 2, 2023
4f35c49
modify documentation of `handleMiddleClickEvent`
vladarama Aug 2, 2023
7d08ebd
improve `handleMiddleClickEvent` documentation
vladarama Aug 2, 2023
e58abd1
Merge branch 'master' of https://github.com/vladarama/theia into midd…
vladarama Aug 7, 2023
a642010
fix right-clicking opening tree nodes
vladarama Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/core/src/browser/tree/tree-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1248,9 +1248,11 @@ export class TreeWidget extends ReactWidget implements StatefulWidget {
* @param event the middle-click mouse event.
*/
protected handleAuxClickEvent(node: TreeNode | undefined, event: React.MouseEvent<HTMLElement>): void {
this.model.openNode(node);
if (SelectableTreeNode.is(node)) {
this.model.selectNode(node);
if (event.button === 1) {
this.model.openNode(node);
if (SelectableTreeNode.is(node)) {
this.model.selectNode(node);
}
}
event.stopPropagation();
}
Expand Down
Loading