Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web plugin initialization #12787

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix web plugin initialization #12787

merged 1 commit into from
Jul 31, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Jul 31, 2023

What it does

Closes #12786

Instead of registering a custom static route handler to context, we simply move the web plugin initialization file to lib/frontend/context so that it can be handled by the general static frontend file handler. This makes the file fetching independent of whether the application backend is currently bundled.

How to test

  1. Start the application and ensure that http://localhost:3000/context/plugin-vscode-init-fe.js serves the file correctly.
  2. Install a web plugin and assert that it works as expected. See here for more info.

Review checklist

Reminder for reviewers

@msujew msujew added the vscode issues related to VSCode compatibility label Jul 31, 2023
@tortmayr tortmayr self-requested a review July 31, 2023 17:10
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The plugin-vscode-init-fe.js is now correctly servend and my test frontend plugin works as expected. 👍🏼

@msujew msujew added plug-in system issues related to the plug-in system and removed vscode issues related to VSCode compatibility labels Jul 31, 2023
@msujew msujew merged commit 16141bf into master Jul 31, 2023
6 checks passed
@msujew msujew deleted the msujew/fix-web-plugins branch July 31, 2023 20:09
@github-actions github-actions bot added this to the 1.41.0 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Web extensions no longer load
2 participants