Stub ShareProvider API #12747
Merged
Stub ShareProvider API #12747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a stub implementation for eclipse-theia#12744 Contributed by STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder
force-pushed
the
12744_stub_share_provider
branch
from
329cf09
to
8a917af
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This is a stub implementation for #12744. Since the API just registers a provider, we can safely stub it.
Contributed by STMicroelectronics
How to test
We can test that the stubbing works by using the github plugin v. 1.80.0 (https://github.com/eclipse-theia/theia/files/12121875/github-1.80.0.zip).
The test is as follows:
Unfortunately, the github plugin will first run into another exception until we have merged #12743. So we'll probably best just wait until that one is merged.
Review checklist
Reminder for reviewers