Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab-bar startup error #12659

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fix tab-bar startup error #12659

merged 1 commit into from
Jun 29, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Jun 28, 2023

What it does

After #12593, an error appears in the console when starting the application, since renderData[overflowStartIndex] is undefined. This is a minor fix to check that this error cannot appear.

How to test

Start the application and confirm that the error does not appear in the console. The original feature should behave as expected.

Review checklist

Reminder for reviewers

@msujew
Copy link
Member Author

msujew commented Jun 28, 2023

cc @tortmayr

@tortmayr tortmayr self-requested a review June 29, 2023 06:25
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for fixing this. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants