Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade msgpackr #12600

Closed
wants to merge 1 commit into from
Closed

deps: upgrade msgpackr #12600

wants to merge 1 commit into from

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jun 8, 2023

What it does

Fixes: #12499.

The commit includes the following:

  • upgrades msgpackr to fix an issue with infinite recursion (causes maximum callstack errors)
  • updates our migration guide for downstream adopters on how to fix the issue in the meantime

How to test

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Jun 8, 2023
@vince-fugnitto vince-fugnitto self-assigned this Jun 8, 2023
@vince-fugnitto vince-fugnitto force-pushed the vf/msgpackr-upgrade branch 3 times, most recently from 30a096a to b15f561 Compare June 22, 2023 14:59
The commit upgrades `msgpackr` to a version which fixes the infinite
recursion error caused by a problematic DTO calling `toJSON` which
references itself.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto
Copy link
Member Author

I need to continue to investigate the issue with the upgrade of msgpackr where the references-view exposed a bug in which we do not send the proper DTO, failing the references-view.

@vince-fugnitto vince-fugnitto mentioned this pull request Jul 11, 2023
1 task
@vince-fugnitto vince-fugnitto marked this pull request as draft July 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Using msgpackr@^1.9.0 causes maximum call stack exceeded error
1 participant