Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JsonRpcProxyFactory and related types #12588

Merged
merged 2 commits into from
Jun 22, 2023

Commits on Jun 20, 2023

  1. Rename JsonRpcProxyFactory and related types

    - Rename `JsonRpcProxyFactory` and related types to `RpcProxyFactory` (Rpc*). The naming scheme was a remainder of the old vscode jsonr-rpc based protocol.
      By simply using the `Rpc` suffix the class names are less misleading and protocol agnostic.
    - Keep deprecated declarations of the old `JsonRpc*` namespace. The components are heavily used by adopters so we should maintain this deprecated symbols for a while to enable graceful migration without hard API breaks.
    Naturally this is open for discussion, but judging from the files I had to touch in the core framework alone I think it's definitely 
    a good idea to give adopters a grace period.
    
    Complementary website PR: eclipse-theia/theia-website#422
    
    Fixes #12581
    Contributed on behalf of STMicroelectronics
    tortmayr committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c984e80 View commit details
    Browse the repository at this point in the history
  2. Update changelog

    tortmayr committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    da390fc View commit details
    Browse the repository at this point in the history