Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builtin-extension-pack v1.77.0 #12576

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

alvsan09
Copy link
Contributor

What it does

The use of this latest extension pack will replace the following plugins e.g. when using the command

yarn download:plugins

From plugin:
vscode.image-preview

To:
vscode.media-preview

How to test

Review checklist

  1. Remove the plugins/ directory from your theia repository.
  2. Build theia and run the following command

yarn download:plugins

  1. Verify that the following plugin is not longer downloaded
    From plugin:
    vscode.image-preview

  2. Verify that the following plugin is present
    vscode.media-preview

  3. Verify that the expected plugins are present under the plugins/ folder.

Reminder for reviewers

The use of this latest extension pack will replace the following
plugins e.g. when using the command `yarn download:plugins`

From:
vscode.image-preview

To:
vscode.media-preview

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
@alvsan09 alvsan09 added the plug-in system issues related to the plug-in system label May 29, 2023
@vince-fugnitto vince-fugnitto added the builtins Issues related to VS Code builtin extensions label May 29, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alvsan09 alvsan09 merged commit d6b5c5c into master May 30, 2023
@alvsan09 alvsan09 deleted the asl/extension_pack_1.77.0 branch May 30, 2023 13:05
@github-actions github-actions bot added this to the 1.39.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions plug-in system issues related to the plug-in system
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants