vscode: add TerminalQuickFixProvider API stubbing
#12532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
vscode
vince-fugnitto
force-pushed
the
vf/builtin-terminalQuickFixProvider
branch
from
30c9312
to
1346558
Compare
alvsan09
approved these changes
May 18, 2023
The commit adds the stubbing for the proposed `TerminalQuickFixProvider` API which was necessary for the `vscode.npm` builtin to successfully activate at version `v1.77.0`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/builtin-terminalQuickFixProvider
branch
from
1346558
to
d90dd86
Compare
marcdumais-work
approved these changes
May 18, 2023
tsmaeder
pushed a commit
to tsmaeder/theia
that referenced
this pull request
May 23, 2023
The commit adds the stubbing for the proposed `TerminalQuickFixProvider` API which was necessary for the `vscode.npm` builtin to successfully activate at version `v1.77.0`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes: #12522.
The pull-request adds stubbing for the proposed
TerminalQuickFixProviderVS Code API.The API was necessary in order for
vscode.npm@1.77.0to successfully activate.How to test
vscode.npmbuiltin with1.77.0(npm-1.77.0.zip)theiaas a workspacenpm scriptsin the explorer is correctly populated (functionality like running a script should work)Review checklist
Reminder for reviewers