Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: Support LogOutputChannel #12429

Merged
merged 4 commits into from
Apr 21, 2023
Merged

plugin: Support LogOutputChannel #12429

merged 4 commits into from
Apr 21, 2023

Commits on Apr 21, 2023

  1. plugin: Support LogOutputChannel 

    - Support LogOutputChannel
- Support LogLevel
- Support in namespace/env: logLevel & onDidChangeLogLevel
- Remark: Needs further extension of application to fully support all aspects of a LogOutputViewChannel (i.e. developer logger service, logging to file, extension of output view UI)

Resolves eclipse-theia#12017

Contributed on behalf of STMicroelectronics.

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
    @ndoschek
    ndoschek committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    25ab324 View commit details
    Browse the repository at this point in the history

  2. Address review comments 

    - Ensure options to identify LogOutputChannel is never optional
- LogOutputChannelImpl extends OutputChannelImpl instead of vscode's AbstractMessageLogger
- Remove obsolete type converter again
- Update Changelog

Contributed on behalf of STMicroelectronics.

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
    @ndoschek
    ndoschek committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    6ce5618 View commit details
    Browse the repository at this point in the history

  3. Address review comments #2 

    - Ensure LogOutputview is validated before logging or appending content
- Simplify processing of error objects
- Simplify formatting of arguments in log messages
- Update Changelog

Contributed on behalf of STMicroelectronics.

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
    @ndoschek
    ndoschek committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    c930230 View commit details
    Browse the repository at this point in the history

  4. Address review comments #3 

    Contributed on behalf of STMicroelectronics.

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
    @ndoschek
    ndoschek committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a9067c8 View commit details
    Browse the repository at this point in the history