Fix DnD of files from OS Explorer into Tree Views #12409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clears "local transfers" when drag ends, preventing the items from a previous D&D operation to spill over to the next one. Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder
force-pushed
the
12404_fix_files_check
branch
from
6d40686
to
d2a73c0
Compare
msujew
added
tree
tortmayr
approved these changes
Apr 27, 2023
jonah-iden
pushed a commit
to jonah-iden/theia
that referenced
this pull request
May 2, 2023
…lipse-theia#12409) Also clears "local transfers" when drag ends, preventing the items from a previous D&D operation to spill over to the next one. Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com> Co-authored-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes dragging files from the OS explorer into tree views contributed via VS Code API. The problem was caused by a wrong check in the
dragOverhandler in the tree view (https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/files). Also discovered that thelocalDataTransferused to transfer objects within the plugin host was not cleared when first dragging locally, then from outside the Theia application.Contributed on behalf of STMicroelectronics
Fixes #12404
How to test
We can reuse the test procedure from #12065.
Review checklist
Reminder for reviewers