fixed #12392. Tab indices now updated #12400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonah-iden
force-pushed
the
jiden/tabs-delete-index-fix
branch
from
a98e2df
to
6c1e99e
Compare
There was a problem hiding this comment.
I still notice errors with this approach:
rpc-message-encoder.ts:184 Uncaught (in promise) Error: Tab close updated received for index 3 which does not exist
at TabGroupExt.acceptTabOperation (/workspace/theia/packages/plugin-ext/lib/plugin/tabs.js:156:23)
at TabsExtImpl.$acceptTabOperation (/workspace/theia/packages/plugin-ext/lib/plugin/tabs.js:286:27)
at /workspace/theia/packages/plugin-ext/lib/common/proxy-handler.js:91:71
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async RpcProtocol.handleRequest (/workspace/theia/packages/core/lib/common/message-rpc/rpc-protocol.js:167:28)
Steps:
- open 4 editors
- close the third editor (2nd last)
- close the last editor
jonah-iden
force-pushed
the
jiden/tabs-delete-index-fix
branch
from
a02a1e7
to
9f1a51b
Compare
msujew
reviewed
Apr 20, 2023
vince-fugnitto
approved these changes
Apr 21, 2023
msujew
force-pushed
the
jiden/tabs-delete-index-fix
branch
from
9b20e39
to
964a1ab
Compare
vince-fugnitto
force-pushed
the
jiden/tabs-delete-index-fix
branch
2 times, most recently
from
b53e89d
to
b0fff47
Compare
vince-fugnitto
force-pushed
the
jiden/tabs-delete-index-fix
branch
from
b0fff47
to
2a39366
Compare
|
@vince-fugnitto merge this one? |
after deleting and moving a tab Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
vince-fugnitto
force-pushed
the
jiden/tabs-delete-index-fix
branch
from
ce564f0
to
023821c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after deleting and moving a tab
What it does
Fixes #12392
updates tabs indeces of all tabs in a group when a tab is deleted or moved
How to test
as described in the issue
Review checklist
Reminder for reviewers