Improve localization for preferences and monaco #12378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vince-fugnitto FYI I just saw that my changes broke the playwright tests, see here. I fixed them just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12372
Fixes a few minor discrepencies between how VSCode localizes preferences and how Theia does it. Also adds a few translation calls where they were missing.
The
test.svgfile deletion is a leftover fix from #9864. The view has been usingcodicon('beaker')for quite some time now.How to test
Install a localization pack and confirm that everything is localized as expected.
Review checklist
Reminder for reviewers