fix monaco suggest list highlight color overlap in light theme

[venciallee]

What it does

Closes: #12048.

How to test

1. Suggest list highlight should work as expected.
2. Following steps from Unreadable content assist selection #12048 and no highlight color overlap

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

[tsmaeder]

@vince-fugnitto, @venciallee from reading through the comments, I'm not sure if we're going to go forward with this change.

[vince-fugnitto]

@vince-fugnitto, @venciallee from reading through the comments, I'm not sure if we're going to go forward with this change.

Right, the pull-request cannot be merged as is as it introduces regressions to other menus and stylings.
@venciallee are you still interested in contributing a fix?

[venciallee]

Yep, Let me fix it in the next few days. Sorry for replying so late.

[venciallee]

Yep, Let me fix it in the next few days. Sorry for replying so late.

Done, Already work for me in light/dark/red theme, please review again @vince-fugnitto

[vince-fugnitto]

I think it's closer, but there is still a regression with the matching highlight:

before (master);

after-fuzzy.mp4

after (this pr):

before-fuzzy.mp4

The blue highlight from the theme when it matches the query is not being applied with the recent changes.

[venciallee]

I think it's closer, but there is still a regression with the matching highlight:

before (master);

after-fuzzy.mp4
after (this pr):

before-fuzzy.mp4
The blue highlight from the theme when it matches the query is not being applied with the recent changes.

Thanks for your review.

I test it in master branch(commit 877f962), and .quick-input-list .highlight is light blue. Did i missing something?

Screen.Recording.2023-04-29.at.16.39.41.mov

Here's the .quick-input-list .highlight

[vince-fugnitto]

I re-reviewed and the changes look good to me, I was confused by the fact that I thought master handled the fuzzy highlighting color from themes better but this pr is going in the right direction.

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

[venciallee]

I re-reviewed and the changes look good to me, I was confused by the fact that I thought master handled the fuzzy highlighting color from themes better but this pr is going in the right direction.

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

Thanks, Already signed ECA with account venciallee@gmail.com

[vince-fugnitto]

Thanks, Already signed ECA with account venciallee@gmail.com

@venciallee sound good, the check fails because the authorship and your eca email do not match:

From bdc7a9d489b35191344cc9f882ac85c8ea1f86c2 Mon Sep 17 00:00:00 2001
From: liwenchao <liwenchao.24@bytedance.com>
Date: Tue, 18 Apr 2023 13:28:38 +0800
Subject: [PATCH]  fix monaco suggest list highlight color overlap in light
 theme

Signed-off-by: vencial lee <venciallee@gmail.com>

...

One being the bytedance email and the other your gmail.

[venciallee]

Thanks, Already signed ECA with account venciallee@gmail.com

@venciallee sound good, the check fails because the authorship and your eca email do not match:

From bdc7a9d489b35191344cc9f882ac85c8ea1f86c2 Mon Sep 17 00:00:00 2001
From: liwenchao <liwenchao.24@bytedance.com>
Date: Tue, 18 Apr 2023 13:28:38 +0800
Subject: [PATCH]  fix monaco suggest list highlight color overlap in light
 theme

Signed-off-by: vencial lee <venciallee@gmail.com>

...

One being the bytedance email and the other your gmail.

Thanks for remind. Already commit with "venciallee@gmail.com" account.

[vince-fugnitto]

@venciallee the behavior and changes look good to me, do you mind rebasing the pull-request (I'm hoping it would fix some of the CI failures we are noticing).

[vince-fugnitto]

LGTM 👍 Thank you for rebasing, the CI now successfully passes