keybindings: search improvement #12312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FernandoAscencio do you mind rebasing the pull-request against the latest master? |
FernandoAscencio
force-pushed
the
fa/keyboardSearchImprovement
branch
from
c1ca440
to
952a0d6
Compare
|
@vince-fugnitto |
FernandoAscencio
force-pushed
the
fa/keyboardSearchImprovement
branch
from
952a0d6
to
c344b99
Compare
FernandoAscencio
force-pushed
the
fa/keyboardSearchImprovement
branch
from
c344b99
to
b88f17e
Compare
|
@colin-grant-work |
FernandoAscencio
force-pushed
the
fa/keyboardSearchImprovement
branch
from
398f15f
to
8a5623a
Compare
improvement that aims to reduce the number of result when searching keys in keybindings. Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio
force-pushed
the
fa/keyboardSearchImprovement
branch
from
e1b834b
to
6336426
Compare
vince-fugnitto
added
keybindings
vince-fugnitto
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11873
This commit aims to improve the keybinding search results in the Keyboard Shortcut Widget.
How to test
Similar to the linked issue.
Notes
Ctrl+U should show keybindings with
CtrlandU, with the following being examples that may or may not exist already.Ctrl+UCtrl+Alt+UCtrl+TUCtrl+KCtrl+U.Other search terms that should work for finding
Ctrl+Uare 'Ctrl U', 'U', 'Ctrl' and 'Ctrl+'. These should includeCtrl+Uin the results.Review checklist
Reminder for reviewers